Skip to content

Conversation

@luissson
Copy link

@luissson luissson commented May 5, 2021

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

  • Has your PR been rebased against the latest commit within the target branch (typically develop)?

  • Is your initial contribution a single, squashed commit?

  • Does gradlew build run cleanly?

  • Have you written or updated unit tests to verify your changes?

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:

Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.

@luissson luissson force-pushed the feature/GEODE-9239 branch 3 times, most recently from 202f460 to 1a08005 Compare May 6, 2021 00:09
- remove ExistsDUnitTest
- remove ExpireDUnitTest
@luissson luissson force-pushed the feature/GEODE-9239 branch from 1a08005 to 7361410 Compare May 6, 2021 00:11
@jdeppe-pivotal jdeppe-pivotal added the redis Issues related to the geode-for-redis module label May 6, 2021
@jdeppe-pivotal jdeppe-pivotal marked this pull request as ready for review May 6, 2021 15:02
@jdeppe-pivotal jdeppe-pivotal merged commit 8be8ebf into apache:develop May 6, 2021
luissson pushed a commit to luissson/geode that referenced this pull request May 6, 2021
sabbey37 pushed a commit that referenced this pull request May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

redis Issues related to the geode-for-redis module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants