Skip to content

Fix codeowners rules that weren't capturing what they were intended to #6448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
onichols-pivotal merged 3 commits into from
May 6, 2021
Merged

Fix codeowners rules that weren't capturing what they were intended to #6448

onichols-pivotal merged 3 commits into from
May 6, 2021

Conversation

@onichols-pivotal
Copy link
Contributor

@onichols-pivotal onichols-pivotal commented May 6, 2021

  • add missing package to dlock section
  • add missing sanctionedDataSerializables.txt and excludedClasses.txt to serialization section
  • add missing apache license.txt to licenses section
  • re-order rules where a more-general catchall was inadvertently overriding more-specific targeted rules

@onichols-pivotal onichols-pivotal requested a review from dickcav May 6, 2021 20:24
@onichols-pivotal onichols-pivotal merged commit 5ec5c8f into apache:develop May 6, 2021
@onichols-pivotal onichols-pivotal deleted the fix-CODEOWNERS-rule-that-was-overly-broad branch May 6, 2021 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dickcav dickcav dickcav approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@onichols-pivotal @dickcav