Skip to content

Conversation

@luissson
Copy link

@luissson luissson commented May 10, 2021

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

  • Has your PR been rebased against the latest commit within the target branch (typically develop)?

  • Is your initial contribution a single, squashed commit?

  • Does gradlew build run cleanly?

  • Have you written or updated unit tests to verify your changes?

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:

Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.

@luissson luissson changed the title GEIDE-9239: Restructure Key-related DUnit tests to handle cluster mode GEODE-9239: Restructure Key-related DUnit tests to handle cluster mode May 10, 2021
@luissson luissson force-pushed the feature/GEODE-9239 branch 2 times, most recently from 4066cb0 to c944859 Compare May 10, 2021 19:20
@luissson luissson marked this pull request as ready for review May 10, 2021 19:25
- update PersistDUnitTest to use JedisCluster
- update RenameDUnitTest to use JedisCluster
- update ExpireDUnitTest to use JedisCluster
- remove ExistsDUnitTest

Co-authored-by: jhutchison <jhutchison@vmware.com>
@luissson luissson force-pushed the feature/GEODE-9239 branch from c944859 to 4879f79 Compare May 10, 2021 19:31
@jdeppe-pivotal jdeppe-pivotal added the redis Issues related to the geode-for-redis module label May 11, 2021
@jdeppe-pivotal jdeppe-pivotal merged commit f6efb4b into apache:develop May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

redis Issues related to the geode-for-redis module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants