GEODE-8772: Assign TCP Server test ports in test JVM #6472
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make TcpServerProductVersionDUnitTest assign the locator port in the test JVM rather than in child VMs. An upcoming change to AvailablePortHelper will improve how it assigns ports to better support tests running in parallel outside of docker. A child VM running an older version of Geode (as happens in this test) will have an out-of-date implementation of AvailablePortHelper, and so may assign a port that is in use by another test running in parallel.
Bill
approved these changes
May 13, 2021
Contributor
Bill
left a comment
Bill
left a comment
There was a problem hiding this comment.
Approved.
Made one optional suggestion below…
|
|
||
| private int createLocator(VM memberVM, boolean usingOldVersion) { | ||
| private int createLocator(VM memberVM) { | ||
| final int port = AvailablePortHelper.getRandomAvailableTCPPort(); |
Contributor
There was a problem hiding this comment.
One minor tweak might be to move this definition closer to the first point of use down on line 262.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make TcpServerProductVersionDUnitTest assign the locator port in the
test JVM rather than in child VMs.
An upcoming change to AvailablePortHelper will improve how it assigns
ports to better support tests running in parallel outside of docker. A
child VM running an older version of Geode (as happens in this test)
will have an out-of-date implementation of AvailablePortHelper, and so
may assign a port that is in use by another test running in parallel.