GEODE-8772: SessionsAndCrashesDUnitTest assign app port #6497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change `SessionsAndCrashesDUnitTest` to assign its test app's server port, rather than using Spring's fixed default server port 8080. PROBLEM `SessionsAndCrashesDUnitTest` was running its test app using Spring's fixed default server port 8080. If this test runs outside of Docker, the fixed default port may be in use in another test.
demery-pivotal
requested review from
jdeppe-pivotal,
nonbinaryprogrammer,
ringles,
sabbey37 and
upthewaterspout
as code owners
sabbey37
approved these changes
May 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
SessionsAndCrashesDUnitTestto assign its test app's serverport, rather than using Spring's fixed default server port 8080.
PROBLEM
SessionsAndCrashesDUnitTestwas running its test app using Spring'sfixed default server port 8080. If this test runs outside of Docker,
the fixed default port may be in use in another test.