GEODE-8772: Fix ClusterComms test port conflicts #6583
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change `ClusterCommunicationsDUnitTest.performARollingUpgrade()` to disable the HTTP service. BACKGROUND I am working on a project to allow Geode tests to run in parallel outside of Docker. Running in parallel outside of Docker requires that tests not start services using default ports. This commit prepares for those changes. PROBLEMS When `ClusterCommunicationsDUnitTest.performARollingUpgrade()` upgrades the locator, it starts the new locator with HTTP service enabled on the default port (7070). If another test running in parallel also uses this default port, at least one will throw an exception when it attempts to bind. THIS COMMIT Change `ClusterCommunicationsDUnitTest` to start the upgraded locator with HTTP service disabled. The test does not use the HTTP service.
demery-pivotal
requested review from
boglesby,
dschneider-pivotal,
kirklund and
nabarunnag
as code owners
agingade
approved these changes
Jun 9, 2021
dschneider-pivotal
approved these changes
Jun 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
ClusterCommunicationsDUnitTest.performARollingUpgrade()todisable the HTTP service.
BACKGROUND
I am working on a project to allow Geode tests to run in parallel
outside of Docker. Running in parallel outside of Docker requires that
tests not start services using default ports.
This commit prepares for those changes.
PROBLEMS
When
ClusterCommunicationsDUnitTest.performARollingUpgrade()upgradesthe locator, it starts the new locator with HTTP service enabled on the
default port (7070). If another test running in parallel also uses this
default port, at least one will throw an exception when it attempts to
bind.
THIS COMMIT
Change
ClusterCommunicationsDUnitTestto start the upgraded locatorwith HTTP service disabled. The test does not use the HTTP service.