GEODE-6588: Cleanup multi-user auth. #6684
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jake-at-work
requested review from
Bill,
agingade and
echobravopapa
as code owners
jake-at-work
force-pushed
the
wip/auth-cleanup
branch
from
fe2d02c to
6377e48
Compare
Bill
requested changes
Jul 22, 2021
Contributor
Bill
left a comment
Bill
left a comment
There was a problem hiding this comment.
Mostly congratulations on cleaning up the code and making it easier to understand.
A couple requests to eliminate StringBuilders you introduced.
geode-core/src/main/java/org/apache/geode/cache/client/internal/OpExecutorImpl.java
Show resolved
Hide resolved
geode-core/src/main/java/org/apache/geode/cache/client/internal/OpExecutorImpl.java
Show resolved
Hide resolved
geode-core/src/main/java/org/apache/geode/cache/client/internal/OpExecutorImpl.java
Show resolved
Hide resolved
...core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ClientProxyMembershipID.java
Show resolved
Hide resolved
...core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ClientProxyMembershipID.java
Show resolved
Hide resolved
...core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ClientProxyMembershipID.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While spending some time in multi-user auth I cleaned up some of the classes I was spending time in understanding.