GEODE-9169: remove netty context switch #6725
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of submitting commands to a background executor, this removes that context switch and performs the command right on the netty thread. Removing the context switch provides a significant performance improvement. Signed-off-by: Donal Evans <doevans@vmware.com>
nonbinaryprogrammer
force-pushed
the
GEODE-9169-remove-netty-context-switch
branch
from
4f949e3 to
9e52708
Compare
nonbinaryprogrammer
requested review from
DonalEvans,
jdeppe-pivotal and
upthewaterspout
as code owners
jdeppe-pivotal
requested changes
Aug 17, 2021
| new ExecutionHandlerContext(socketChannel, regionProvider, pubsub, | ||
| allowUnsupportedSupplier, shutdownInvoker, redisStats, backgroundExecutor, | ||
| redisPasswordBytes, getPort(), member)); | ||
| allowUnsupportedSupplier, shutdownInvoker, redisStats, redisPasswordBytes, |
Contributor
There was a problem hiding this comment.
The backgroundExecutor removed here should also be removed from the constructor and can then also be removed from GeodeRedisServer.
Contributor
Author
There was a problem hiding this comment.
thanks!
DonalEvans
approved these changes
Aug 17, 2021
| regionProvider, pubSub, | ||
| this::allowUnsupportedCommands, this::shutdown, port, bindAddress, redisStats, | ||
| redisCommandExecutor, member); | ||
| member); |
Contributor
There was a problem hiding this comment.
This executor can be completely removed from the class now.
| regionProvider, pubSub, | ||
| this::allowUnsupportedCommands, this::shutdown, port, bindAddress, redisStats, | ||
| redisCommandExecutor, member); | ||
| member); |
Contributor
There was a problem hiding this comment.
shouldn't the redisCommandExecutor field be removed from this class?
| } | ||
|
|
||
| commandQueue.clear(); | ||
| commandQueue.offer(TERMINATE_COMMAND); |
Contributor
There was a problem hiding this comment.
It looks like TERMINATE_COMMAND is no longer used. This class creates in a private static final so I think that static should also be removed
jdeppe-pivotal
approved these changes
Aug 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop)?Is your initial contribution a single, squashed commit?
Does
gradlew buildrun cleanly?Have you written or updated unit tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.