Skip to content

Conversation

@DonalEvans
Copy link
Contributor

  • Close client connection on CancelException
  • Fix handling of RedisCommandParserException
  • Remove unused constants

Authored-by: Donal Evans doevans@vmware.com

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

  • Has your PR been rebased against the latest commit within the target branch (typically develop)?

  • Is your initial contribution a single, squashed commit?

  • Does gradlew build run cleanly?

  • Have you written or updated unit tests to verify your changes?

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

 - Close client connection on CancelException
 - Fix handling of RedisCommandParserException
 - Remove unused constants

Authored-by: Donal Evans <doevans@vmware.com>
@DonalEvans DonalEvans added the redis Issues related to the geode-for-redis module label Sep 15, 2021
Copy link
Contributor

@upthewaterspout upthewaterspout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wondering why we never saw a problem with CacheClosedException, honestly. I looked at the redis source code, and I don't see that "The server is shutting down" error message sent back to a client anywhere, so I would be surprised if that was being handled correctly by clients.

@DonalEvans
Copy link
Contributor Author

I wondering why we never saw a problem with CacheClosedException, honestly. I looked at the redis source code, and I don't see that "The server is shutting down" error message sent back to a client anywhere, so I would be surprised if that was being handled correctly by clients.

It's surprising, yeah. I wonder if it's possible we got lucky and were just never doing anything that would cause a CacheClosedException to be thrown to here.

@DonalEvans DonalEvans merged commit d0113fc into apache:develop Sep 16, 2021
@DonalEvans DonalEvans deleted the feature/GEODE-9552 branch September 16, 2021 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

redis Issues related to the geode-for-redis module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants