GEODE-9575: improve how publish executes a function #6873
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the set of members hosting the redis region. PubSubImpl now has a PublishFunction in place of the old anonymous inner class. PubSubDUnitTest had a timing issue after killing a server. The next test would fail due to the state left around by the test that did the kill. Now this test gives each test method a new clean slate and is passing consistently.
dschneider-pivotal
requested review from
DonalEvans,
jdeppe-pivotal,
kirklund,
nonbinaryprogrammer,
ringles and
upthewaterspout
as code owners
jdeppe-pivotal
approved these changes
Sep 16, 2021
Contributor
jdeppe-pivotal
left a comment
jdeppe-pivotal
left a comment
There was a problem hiding this comment.
I left one comment, but not a big deal if you want to leave it as is.
...apis-compatible-with-redis/src/main/java/org/apache/geode/redis/internal/RegionProvider.java
Outdated
Show resolved
Hide resolved
DonalEvans
approved these changes
Sep 16, 2021
Doing it as a function has an extra context switch so doing it inline will be a bit faster.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the set of members hosting the redis region.
anonymous inner class.
The next test would fail due to the state left around by
the test that did the kill. Now this test gives each test
method a new clean slate and is passing consistently.
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop)?Is your initial contribution a single, squashed commit?
Does
gradlew buildrun cleanly?Have you written or updated unit tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?