GEODE-9623: Add Radish COMMAND command#6907
Merged
jdeppe-pivotal merged 7 commits intoapache:developfrom Sep 29, 2021
Merged
Conversation
jdeppe-pivotal
changed the title
jdeppe-pivotal
requested review from
DonalEvans,
dschneider-pivotal,
kirklund,
nonbinaryprogrammer and
onichols-pivotal
as code owners
jdeppe-pivotal
requested review from
ringles and
upthewaterspout
as code owners
onichols-pivotal
approved these changes
Sep 28, 2021
...is-compatible-with-redis/src/main/java/org/apache/geode/redis/internal/RedisCommandType.java
Outdated
Show resolved
Hide resolved
...is-compatible-with-redis/src/main/java/org/apache/geode/redis/internal/RedisCommandType.java
Outdated
Show resolved
Hide resolved
...is-compatible-with-redis/src/main/java/org/apache/geode/redis/internal/RedisCommandType.java
Outdated
Show resolved
Hide resolved
DonalEvans
approved these changes
Sep 28, 2021
Contributor
DonalEvans
left a comment
DonalEvans
left a comment
There was a problem hiding this comment.
Just a few clean-up suggestions.
...edis/src/main/java/org/apache/geode/redis/internal/parameters/SpopParameterRequirements.java
Outdated
Show resolved
Hide resolved
...ith-redis/src/main/java/org/apache/geode/redis/internal/executor/server/CommandExecutor.java
Outdated
Show resolved
Hide resolved
...grationTest/java/org/apache/geode/redis/internal/executor/server/CommandIntegrationTest.java
Outdated
Show resolved
Hide resolved
...grationTest/java/org/apache/geode/redis/internal/executor/server/CommandIntegrationTest.java
Outdated
Show resolved
Hide resolved
...ompatible-with-redis/src/main/java/org/apache/geode/redis/internal/parameters/Parameter.java
Outdated
Show resolved
Hide resolved
- Refactor of all parameter requirements and convert to structure that can hold meta info about a command. - Does not yet contain info about the 'type' or 'flag' associated with commands - for example 'write' or 'readonly'.
jdeppe-pivotal
force-pushed
the
feature/GEODE-9623-add-command-command
branch
from
8f36096 to
2c9e284
Compare
dschneider-pivotal
approved these changes
Sep 29, 2021
DonalEvans
approved these changes
Sep 29, 2021
upthewaterspout
approved these changes
Sep 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
can hold meta info about a command.
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop)?Is your initial contribution a single, squashed commit?
Does
gradlew buildrun cleanly?Have you written or updated unit tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?