GEODE-9629: previous fix missed removing this other public getter #6972
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t broke compatibility
onichols-pivotal
requested review from
boglesby,
gesterzhou,
kirklund and
nabarunnag
as code owners
boglesby
approved these changes
Oct 11, 2021
onichols-pivotal
deleted the
GEODE-9629-also-shouldnt-have-added-new-getter
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
first fix #6915 removed the errant setter. this fix removes the getter. (both were introduced in 1.15, so removing it now before we ship 1.15.0 does not break compatibility with any released version of Geode)
adding new methods to a public interface like GatewaySender is a breaking change for other implementations of this interface, such as in Spring Data Geode project. We can consider bringing these only when a new major is proposed (e.g. Geode 2.0)
All of the Geode code that uses this getter already uses AbstractGatewaySender anyway, so the easiest fix is just to push this down for now.