GEODE-9038: Ignore AlertingIOException in ShutdownAllDUnitTest #6982
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add ignored exception AlertingIOException to testShutdownAllWithMembersWaiting.
kirklund
requested review from
BenjaminPerryRoss,
boglesby,
mhansonp and
nabarunnag
as code owners
mhansonp
approved these changes
Oct 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ignored exception AlertingIOException to
testShutdownAllWithMembersWaiting.
PROBLEM
ShutdownAllDUnitTest fails grep for suspect strings in CI when the JMX
Manager shuts down while another member is simultaneously sending
it an Alert.
SOLUTION
Add
addIgnoredException(AlertingIOException.class)totestShutdownAllWithMembersWaiting.