GEODE-9677: After provider sends ImageReply, requester could finish e… #6992
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arlier than provider
gesterzhou
requested review from
DonalEvans,
jchen21,
kirklund and
nabarunnag
as code owners
jchen21
reviewed
Oct 13, 2021
| count = getDeltaGIICount(P); | ||
| assertEquals(0, count); | ||
| final int countConst = getDeltaGIICount(P); | ||
| GeodeAwaitility.await().untilAsserted(() -> assertEquals(0, countConst)); |
Contributor
There was a problem hiding this comment.
Once countConst is assigned by getDeltaGIICount(P), its value will not change. If its value is not 0, no matter how long you wait, the assert in the next line still fails.
I was thinking about GeodeAwaitility.await().untilAsserted(() -> assertEquals(0, getDeltaGIICount(P)));.
Please correct me if I am wrong.
Contributor
Author
There was a problem hiding this comment.
You are right. I fixed.
jchen21
approved these changes
Oct 13, 2021
kirklund
approved these changes
Oct 13, 2021
Contributor
kirklund
left a comment
kirklund
left a comment
There was a problem hiding this comment.
Approved! You might want to consider changing the assertion to use org.assertj.core.api.Assertions.assertThat but I think it's ready to merge now.
DonalEvans
approved these changes
Oct 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…arlier than provider
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop)?Is your initial contribution a single, squashed commit?
Does
gradlew buildrun cleanly?Have you written or updated unit tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?