Fixing the archiving of benchmark results #7000
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were using the wrong directory name when trying to create a benchmark archive. It was looking for a single directory in the format benchmarks-apache-develop-main-benchmark-base-277-89433-base, but there are actually multiple directories in the format benchmarks-apache-develop-main-benchmark-base-277-89433-base-output-10-13-2021-18-26-22-apache-develop-main-benchmark-base-277-89433-base as well as a text file. Archiving the whole results directory. Also, including a tabular dump of the results in the archive for potentially easier parsing.
upthewaterspout
requested review from
dickcav and
onichols-pivotal
as code owners
Contributor
Author
|
FYI - I tested this script just by hijacking into a completed concourse job and running the modified version. If you'd like to see different tests of this I'm happy to test it other ways as well. |
onichols-pivotal
approved these changes
Oct 14, 2021
dickcav
approved these changes
Oct 14, 2021
ghost
approved these changes
Oct 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were using the wrong directory name when trying to create
a benchmark archive. It was looking for a single directory in the format
benchmarks-apache-develop-main-benchmark-base-277-89433-base, but there
are actually multiple directories in the format
benchmarks-apache-develop-main-benchmark-base-277-89433-base-output-10-13-2021-18-26-22-apache-develop-main-benchmark-base-277-89433-base
as well as a text file.
Archiving the whole results directory. Also, including a tabular
dump of the results in the archive for potentially easier parsing.