GEODE-9050: Backporting the develop version of AbstractPubSubIntegrationTest#7044
Closed
upthewaterspout wants to merge 3 commits intoapache:support/1.14from
Closed
Conversation
onichols-pivotal
approved these changes
Oct 25, 2021
Fixing a race condition in ensureOrderingOfPublishedMessages. This test was expecting the client to receive messages from the server after calling publish, but the events are processed asynchronously on the client. Changing the test to wait for the messages to arrive. Backporting the develop version of this test resulted in new failures, so just fixing the one race condition we're hitting in support/1.14 for this test.
upthewaterspout
force-pushed
the
feature/backport-develop-pubsub-test-GEODE-9050
branch
from
9bc577f to
91fa06e
Compare
This test is not failing for me locally. Adding some debug printouts to try to see what is going on in CI.
Contributor
|
this bump was reverted from develop, so won't be backported at this time |
Contributor
|
this bump was re-applied to develop (but with 4.1.70), so backport is back on...although we'll need to decide if 4.1.68 /w netty-all or 4.1.70 /w specific netty jars is the right path, as well as getting path the failing test. |
Contributor
Author
|
Not using this change for support/1.14, we changed this test a different way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test is now more lenient about when messages are delivered to the client.
We were previously expecting that if we called publish followed by unsubscribe
we would observe messages from the publish operation, which I don't think was
actually true even before but was failing consistently with the updated netty.
Upgrading our netty dependency to 4.1.68.Final