GEODE-9692: enable HashesAndCrashesDUnitTest#7048
Closed
nonbinaryprogrammer wants to merge 3 commits intoapache:developfrom
Closed
GEODE-9692: enable HashesAndCrashesDUnitTest#7048nonbinaryprogrammer wants to merge 3 commits intoapache:developfrom
nonbinaryprogrammer wants to merge 3 commits intoapache:developfrom
Conversation
nonbinaryprogrammer
requested review from
DonalEvans,
dschneider-pivotal,
jdeppe-pivotal,
kirklund,
ringles and
upthewaterspout
as code owners
Contributor
Author
|
stress new test failures are due to connection issues, which are an existing issue not within the scope of this PR |
Contributor
|
The stress-new-test-openjdk8 failure is due to a hang, as the job took over 10 hours to run instead of the usual 40 minutes. Could this job be reran to make sure this isn't a repeat occurrence? |
Contributor
|
Since the only test you changed was HashesAndCrashesDUnitTest it will be the only one run by stressNewTest. It seems like this test can't handle being run by stressNewTest. Maybe it leaves some stuff around between repeats? |
nonbinaryprogrammer
force-pushed
the
GEODE-9692-hashes-and-crashes
branch
from
49f178b to
29dbb7a
Compare
- add retries for hset, set, and sadd commands - make the validation consistent accross all tests - stop the vms after the tests
nonbinaryprogrammer
force-pushed
the
GEODE-9692-hashes-and-crashes
branch
from
82f88e4 to
e710f92
Compare
…ing with port collisions)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I previously checked which Ignored tests pass, I found that this one did not. Since then someone must have fixed whatever issue was causing the failures because now they all pass. I simply removed the @ignore.
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop)?Is your initial contribution a single, squashed commit?
Does
gradlew buildrun cleanly?Have you written or updated unit tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?