GEODE-9784: GFSH connect and start server with username option#7059
Merged
igodwin merged 3 commits intoapache:developfrom Oct 30, 2021
Merged
GEODE-9784: GFSH connect and start server with username option#7059igodwin merged 3 commits intoapache:developfrom
igodwin merged 3 commits intoapache:developfrom
Conversation
igodwin
requested review from
jdeppe-pivotal,
jinmeiliao,
kirklund and
mhansonp
as code owners
Contributor
|
@igodwin If this new command option is user-visible, you'll need to add some doc changes to this PR. LMK if I can help. |
aaronlindsey
approved these changes
Oct 28, 2021
aaronlindsey
left a comment
aaronlindsey
left a comment
There was a problem hiding this comment.
Looks good after the docs changes are made. Nice, simple change. It will be good to have support for --username flag since that name is commonly used.
Author
|
I've updated documentation and added the same option to the |
davebarnes97
approved these changes
Oct 28, 2021
Contributor
davebarnes97
left a comment
davebarnes97
left a comment
There was a problem hiding this comment.
LGTM. (I added & committed a line break in connect.html.md.erb)
- Add connect command option username that aliases user
Added a line break
igodwin
force-pushed
the
GEODE-9784-gfsh-connect-username
branch
from
733eceb to
c617c09
Compare
igodwin
changed the title
jdeppe-pivotal
approved these changes
Oct 29, 2021
mhansonp
approved these changes
Oct 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop)?Is your initial contribution a single, squashed commit?
Does
gradlew buildrun cleanly?Have you written or updated unit tests to verify your changes?