GEODE-9859: Do not copy entry if it is a destroyed entry#7147
Merged
albertogpz merged 2 commits intoapache:developfrom Jan 26, 2022
Merged
GEODE-9859: Do not copy entry if it is a destroyed entry#7147albertogpz merged 2 commits intoapache:developfrom
albertogpz merged 2 commits intoapache:developfrom
Conversation
albertogpz
force-pushed
the
feature/GEODE-9859
branch
from
e2b5188 to
161b91c
Compare
albertogpz
requested review from
boglesby,
gesterzhou and
nabarunnag
as code owners
nabarunnag
requested changes
Dec 8, 2021
Contributor
nabarunnag
left a comment
nabarunnag
left a comment
There was a problem hiding this comment.
A small unit test along with this PR may be needed.
albertogpz
force-pushed
the
feature/GEODE-9859
branch
from
161b91c to
9840399
Compare
albertogpz
force-pushed
the
feature/GEODE-9859
branch
from
9840399 to
10ebed6
Compare
Contributor
Author
@nabarunnag Could you please review the PR? |
albertogpz
force-pushed
the
feature/GEODE-9859
branch
from
10ebed6 to
c651321
Compare
albertogpz
force-pushed
the
feature/GEODE-9859
branch
from
c651321 to
814b04a
Compare
albertogpz
force-pushed
the
feature/GEODE-9859
branch
from
814b04a to
70ddaf5
Compare
Contributor
Author
@nabarunnag Are you ok with the unit test added? Any other thing to change? |
|
@albertogpz Any plans of merging this PR. Also there is a new ticket created in the same area GEODE-9984 can you please look into that (and take ticket ownership) |
Contributor
Author
@agingade I would like to merge but I still need the approval from @nabarunnag |
nabarunnag
approved these changes
Jan 26, 2022
mhansonp
pushed a commit
to mhansonp/geode
that referenced
this pull request
Mar 11, 2022
* GEODE-9859: Do not copy entry if it is a destroyed entry * GEODE-9859: Add unit test after review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop)?Is your initial contribution a single, squashed commit?
Does
gradlew buildrun cleanly?Have you written or updated unit tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?