GEODE-9870: Avoid Radish MOVED error during flushAll in AuthWhileServersRestartDUnitTest #7171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ersRestartDUnitTest - Since servers have been stopped and restarted, as part of the test, buckets may be moving. Occasionally this may still be the case when the test is done and flushAll is cleaning up. To avoid that, make sure that everything is rebalanced before flushAll is called.
jdeppe-pivotal
requested review from
DonalEvans,
dschneider-pivotal,
kirklund,
nonbinaryprogrammer,
ringles and
upthewaterspout
as code owners
dschneider-pivotal
approved these changes
Dec 7, 2021
ringles
reviewed
Dec 7, 2021
...est/java/org/apache/geode/redis/internal/executor/auth/AuthWhileServersRestartDUnitTest.java
Outdated
Show resolved
Hide resolved
DonalEvans
approved these changes
Dec 7, 2021
ringles
requested changes
Dec 7, 2021
Contributor
ringles
left a comment
ringles
left a comment
There was a problem hiding this comment.
Intellij can't find where the "server1" variable is used, either. Can it be removed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
buckets may be moving. Occasionally this may still be the case when
the test is done and flushAll is cleaning up. To avoid that, make sure
that everything is rebalanced before flushAll is called.
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop)?Is your initial contribution a single, squashed commit?
Does
gradlew buildrun cleanly?Have you written or updated unit tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?