GEODE-10011: Do not perform second scan if first scanned entire map#7333
Merged
DonalEvans merged 1 commit intoapache:developfrom Feb 2, 2022
Merged
GEODE-10011: Do not perform second scan if first scanned entire map#7333DonalEvans merged 1 commit intoapache:developfrom
DonalEvans merged 1 commit intoapache:developfrom
Conversation
- The test scanWithNoModificationsDoesNotReturnDuplicates in SizeableBytes2ObjectOpenCustomHashMapWithCursorQuickCheckTest should only perform a second scan if the first one was not a complete scan of the map Authored-by: Donal Evans <doevans@vmware.com>
DonalEvans
requested review from
dschneider-pivotal,
jdeppe-pivotal,
nonbinaryprogrammer,
ringles and
upthewaterspout
as code owners
jdeppe-pivotal
approved these changes
Feb 2, 2022
mhansonp
pushed a commit
to mhansonp/geode
that referenced
this pull request
Mar 11, 2022
…pache#7333) - The test scanWithNoModificationsDoesNotReturnDuplicates in SizeableBytes2ObjectOpenCustomHashMapWithCursorQuickCheckTest should only perform a second scan if the first one was not a complete scan of the map Authored-by: Donal Evans <doevans@vmware.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SizeableBytes2ObjectOpenCustomHashMapWithCursorQuickCheckTest should
only perform a second scan if the first one was not a complete scan of
the map
Authored-by: Donal Evans doevans@vmware.com
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop)?Is your initial contribution a single, squashed commit?
Does
gradlew buildrun cleanly?Have you written or updated unit tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?