Do Not Review #7356
Closed
Do Not Review #7356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jchen21
reviewed
Feb 11, 2022
|
|
||
| Profile[] locProfiles = profiles; // grab current profiles | ||
| for (int i = 0; i < locProfiles.length; i++) { | ||
| if (locProfiles[i].getDistributedMember().getId() == member.getId()) { |
Contributor
There was a problem hiding this comment.
Instead of ==, it should be equals(). Otherwise, it is comparing the references instead of the strings. Or locProfiles[i].getDistributedMember().equals(member) also works.
| ProfileId id = getProfileIdForMember(member); | ||
| logger.warn("Removing profile for member " + member + " profileid = " + id | ||
| + " because we think it is stale"); | ||
| removeId(id, false, false, false); |
Contributor
There was a problem hiding this comment.
I am afraid this could potentially remove the non-stale ServerBucketProfile.
when waiting for a new primary will never succeed.
mhansonp
force-pushed
the
bugfix/GEODE-10039
branch
from
e78680f to
b7fc6a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GEODE-10039: Fix to remove a stale profile when waiting for a new primary will never succeed.