GEODE-10067: Optimize wan-copy region command#7420
Merged
albertogpz merged 1 commit intoapache:developfrom Mar 18, 2022
Merged
Conversation
albertogpz
force-pushed
the
feature/GEODE-10067
branch
from
b82ad3a to
8395c33
Compare
albertogpz
requested review from
boglesby,
gesterzhou and
nabarunnag
as code owners
albertogpz
force-pushed
the
feature/GEODE-10067
branch
from
8395c33 to
33e9ca4
Compare
| private Collection<?> getEntries(Region<?, ?> region, GatewaySender sender) { | ||
| if (region instanceof PartitionedRegion && sender.isParallel()) { | ||
| return ((PartitionedRegion) region).getDataStore().getEntries(); | ||
| return PartitionRegionHelper.getLocalPrimaryData(region).entrySet(); |
Contributor
There was a problem hiding this comment.
Definitely a much better set of data, compared to ALL data entries :D
kohlmu-pivotal
approved these changes
Mar 8, 2022
Contributor
kohlmu-pivotal
left a comment
kohlmu-pivotal
left a comment
There was a problem hiding this comment.
Once all tests pass, this change is approved
albertogpz
force-pushed
the
feature/GEODE-10067
branch
4 times, most recently
from
e843660 to
40eb07d
Compare
When the region to copy is partitioned and the gateway sender is parallel, each gateway sender sends the primary copies of the buckets in that server. Deserialization of the entries is also avoided.
albertogpz
force-pushed
the
feature/GEODE-10067
branch
from
40eb07d to
efdcf0c
Compare
boglesby
approved these changes
Mar 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the region to copy is partitioned and
the gateway sender is parallel, the gateway
sender of each server will read and then send only the primary
copies in the local buckets of that server.
Deserialization of the entries will also avoided.
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop)?Is your initial contribution a single, squashed commit?
Does
gradlew buildrun cleanly?Have you written or updated unit tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?