GEODE-10123: Improve create region checks#7443
Merged
mkevo merged 1 commit intoapache:developfrom Mar 22, 2022
Merged
Conversation
jvarenina
force-pushed
the
feature/GEODE-10123
branch
4 times, most recently
from
2737abc to
82cee52
Compare
jvarenina
requested review from
boglesby,
gesterzhou,
jdeppe-pivotal,
jinmeiliao,
mhansonp and
nabarunnag
as code owners
mhansonp
approved these changes
Mar 18, 2022
Contributor
|
Looks good. Thanks for the explanation of the PR. |
Sometimes the "create region" command executes successfully during servers restart even though region is already available in the cluster configuration. When this happens, cluster configuration contains a duplicated region, so servers throw "org.apache.geode.cache.RegionExistsException" at startup. CreateRegionCommand class checks whether there is already an existing region using the DistributedRegionMXBean service. This service is unreliable during restarts, as it takes some time for the locator to accumulate region information. In addition to checks done against the DistributedRegionMXBean information, this solution introduces the same checks against cluster configuration (if used) stored in locators.
jvarenina
force-pushed
the
feature/GEODE-10123
branch
from
82cee52 to
37e089e
Compare
jinmeiliao
approved these changes
Mar 21, 2022
jvarenina
added a commit
to Nordix/geode
that referenced
this pull request
Mar 22, 2022
Sometimes the "create region" command executes successfully during servers restart even though region is already available in the cluster configuration. When this happens, cluster configuration contains a duplicated region, so servers throw "org.apache.geode.cache.RegionExistsException" at startup. CreateRegionCommand class checks whether there is already an existing region using the DistributedRegionMXBean service. This service is unreliable during restarts, as it takes some time for the locator to accumulate region information. In addition to checks done against the DistributedRegionMXBean information, this solution introduces the same checks against cluster configuration (if used) stored in locators.
jvarenina
added a commit
to Nordix/geode
that referenced
this pull request
Apr 14, 2022
Sometimes the "create region" command executes successfully during servers restart even though region is already available in the cluster configuration. When this happens, cluster configuration contains a duplicated region, so servers throw "org.apache.geode.cache.RegionExistsException" at startup. CreateRegionCommand class checks whether there is already an existing region using the DistributedRegionMXBean service. This service is unreliable during restarts, as it takes some time for the locator to accumulate region information. In addition to checks done against the DistributedRegionMXBean information, this solution introduces the same checks against cluster configuration (if used) stored in locators.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes the "create region" command executes successfully during
servers restart even though region is already available in the cluster
configuration. When this happens, cluster configuration contains a
duplicated region, and servers throw
"org.apache.geode.cache.RegionExistsException" at startup.
CreateRegionCommand checks whether there is already an existing
region using the DistributedRegionMXBean service. This service is
unreliable during restarts, as it takes some time for the locator to
accumulate region information.
In addition to checks done against the DistributedRegionMXBean
information, this solution introduces the same checks against cluster
configuration (if used) stored in locators. This way, the "create region"
command is rejected immediately by the locator instead of the
servers.
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop)?Is your initial contribution a single, squashed commit?
Does
gradlew buildrun cleanly?Have you written or updated unit tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?