GEODE-10149: don't roll radish baseline except on new minor #7472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radish benchmarks use a custom branch/tag on a new minor, the release scripts should reset that to the new minor release however, the scripts are incorrectly resetting it on every patch, oops
…, resetting might be the wrong choice. but, assuming it's older, a new minor is the time to un-custom it. hopefully PR review catches situation where the recommended change is not wanted
dickcav
approved these changes
Mar 22, 2022
onichols-pivotal
deleted the
GEODE-10149-dont-roll-radish-baseline-except-on-new-minor
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
radish benchmarks use a custom branch/tag
on a new minor, the release scripts should reset that to the new minor release
however, the scripts are incorrectly resetting it on every patch, oops
even resetting it on a new minor could be the wrong thing, if the custom baseline on develop is already newer than the point where the release branch was cut, but hopefully that can be caught in PR review if ever a problem; I feel there is bigger concern of forgetting to reset the custom branch when a new minor happens, so best for the script to still do it.