GEODE-10162: Try to find and set version tag if needed #7487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* In geode, version tags are not sent to receiver during GII. When an operation is retried on the receiver, a valid tag is needed so that the operation can be distributed to other peers. Valid version tage will be searched in the cluster and set in the event to make sure the operation is distributed.
pivotal-eshu
requested review from
DonalEvans,
jchen21,
kirklund and
nabarunnag
as code owners
agingade
reviewed
Mar 25, 2022
geode-core/src/main/java/org/apache/geode/internal/cache/DistributedRegion.java
Show resolved
Hide resolved
gesterzhou
approved these changes
Mar 28, 2022
DonalEvans
approved these changes
Mar 29, 2022
geode-core/src/main/java/org/apache/geode/internal/cache/DistributedRegion.java
Show resolved
Hide resolved
geode-core/src/test/java/org/apache/geode/internal/cache/DistributedRegionTest.java
Outdated
Show resolved
Hide resolved
kirklund
approved these changes
Mar 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
operation is retried on the receiver, a valid tag is needed so that the
operation can be distributed to other peers. Valid version tage will
be searched in the cluster and set in the event to make sure the
operation is distributed.
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop)?Is your initial contribution a single, squashed commit?
Does
gradlew buildrun cleanly?Have you written or updated unit tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?