Skip to content

Conversation

@pivotal-eshu
Copy link

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

  • Has your PR been rebased against the latest commit within the target branch (typically develop)?

  • Is your initial contribution a single, squashed commit?

  • Does gradlew build run cleanly?

  • Have you written or updated unit tests to verify your changes?

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

@nabarunnag
Copy link
Contributor

is it because event.getOperation().isEntry() is already called in the callers of this method? and an NPE will be thrown even before the execution reaches till this point ?

@pivotal-eshu pivotal-eshu merged commit b5d6917 into apache:develop Mar 29, 2022
@pivotal-eshu
Copy link
Author

is it because event.getOperation().isEntry() is already called in the callers of this method? and an NPE will be thrown even before the execution reaches till this point ?

The check is now in TXState.attachFilterProfileInformation which executed before the to be removed code path.
if (ev.getOperation() == null) {
// A read op with detect read conflicts does not need filter routing.
continue;
}

@pivotal-eshu pivotal-eshu deleted the feature/GEODE-10182 branch March 29, 2022 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants