GEODE-9955: Add RPUSHX command #7507
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kris-10-0
requested review from
DonalEvans,
dschneider-pivotal,
jdeppe-pivotal,
nonbinaryprogrammer,
ringles and
upthewaterspout
as code owners
jdeppe-pivotal
approved these changes
Mar 28, 2022
Kris-10-0
force-pushed
the
feature/GEODE-9955
branch
from
d915c3e to
3003029
Compare
DonalEvans
requested changes
Mar 30, 2022
geode-for-redis/src/main/java/org/apache/geode/redis/internal/data/RedisList.java
Outdated
Show resolved
Hide resolved
added 5 commits
March 30, 2022 15:27
This implements a version of the Redis RPUSHX command, which is used for list data types. Associated tests were also added. For a list stored at a key, rpushx adds the specified element to the tail of the list. If the key does not exist, no operation will be performed.
This reverts commit 3003029.
This reverts commit dd736a5.
Kris-10-0
force-pushed
the
feature/GEODE-9955
branch
from
2b67747 to
bab72a6
Compare
DonalEvans
approved these changes
Mar 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a version of the Redis RPUSHX command, which is used for
list data types. Associated tests were also added.
For a list stored at a key, rpushx adds the specified element to the tail of the
list. If the key does not exist, no operation will be performed.
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop)?Is your initial contribution a single, squashed commit?
Does
gradlew buildrun cleanly?Have you written or updated unit tests to verify your changes?
[NA] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?