Skip to content

Code cleanup for toVeloxPlan with ProjectRel #10770

@beliefer

Description

@beliefer

Description

The current implementation show below have some optimization points.
core::PlanNodePtr SubstraitToVeloxPlanConverter::toVeloxPlan(const ::substrait::ProjectRel& projectRel)

First, reserve more accurate memory for projectNames and expressions.
Second, eliminate the unnecessary colIdx.
Third, using emplace_back and std::move to reduce copy.

Gluten version

main branch

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions