[VL] Separate filesystem configuration initialization#10540
Merged
marin-ma merged 4 commits intoapache:mainfrom Aug 29, 2025
Merged
[VL] Separate filesystem configuration initialization#10540marin-ma merged 4 commits intoapache:mainfrom
marin-ma merged 4 commits intoapache:mainfrom
Conversation
Contributor
Author
|
@jinchengchenghh Could you help to review? Thanks! |
zhouyuan
approved these changes
Aug 28, 2025
cpp/velox/utils/ConfigExtractor.cc
Outdated
| for (const auto& [key, value] : sparkSuffixes) { | ||
| if (value.first == suffix) { | ||
| return std::optional<S3Config::Keys>(key); | ||
| if (contains(fsType, FileSystemType::kS3)) { |
Member
There was a problem hiding this comment.
Shall we also add else clause here to guard some corner case?
cpp/velox/utils/ConfigExtractor.h
Outdated
| kS3 = 1 << 1, | ||
| kAbfs = 1 << 2, | ||
| kGcs = 1 << 3, | ||
| kAll = (1 << 4) - 1 |
Member
There was a problem hiding this comment.
The code seems a bit complicated, how about using 0, 1, 2, 3 and std::num_limits<uint8_t>::max for kAll?
Contributor
Author
There was a problem hiding this comment.
One bit is used for each fs type and we check if the corresponding bit is set. Seems like 0, 1, 2, 3 can't do the job.
Contributor
Author
There was a problem hiding this comment.
It may not be a trivial code path to only parse two or three fs types. I will update the code
Contributor
Author
|
@zhouyuan Could you help to review again? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getHiveConfignow parses configurations for all kinds of filesystems. It should not parse configurations for other kinds if it's called from a specificVeloxParquetDataSourceimplementation.