[GLUEN-10107][INFRA]Deprecate isUseUniffleShuffleManager from glutenConfig#10558
Merged
zhztheplayer merged 1 commit intoapache:mainfrom Sep 1, 2025
Merged
[GLUEN-10107][INFRA]Deprecate isUseUniffleShuffleManager from glutenConfig#10558zhztheplayer merged 1 commit intoapache:mainfrom
zhztheplayer merged 1 commit intoapache:mainfrom
Conversation
|
Run Gluten Clickhouse CI on x86 |
Contributor
Author
|
@zhztheplayer would you like to help review this modification? |
zhztheplayer
approved these changes
Aug 28, 2025
zjuwangg
force-pushed
the
removeIsUniffConfig
branch
from
d4640eb to
8b97d64
Compare
|
Run Gluten Clickhouse CI on x86 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
The
isUseUniffleShuffleManagerconfiguration was originally introduced in PR #3767. However, subsequent refactoring efforts have relocated the Uniffle-related shuffle manager implementation to thebackends-veloxmodule. This configuration is now obsolete and should be removed. Additionally, we can eliminate the corresponding validation checks in the ClickHouse backends since theUniffleShuffleManagerclass will no longer be present in the classpath of CH-backends.How was this patch tested?
Existing tests.