[GLUTEN-10552][VL] Fix openEuler compiling issue #10564
Merged
zhouyuan merged 2 commits intoapache:mainfrom Aug 28, 2025
Merged
[GLUTEN-10552][VL] Fix openEuler compiling issue #10564zhouyuan merged 2 commits intoapache:mainfrom
zhouyuan merged 2 commits intoapache:mainfrom
Conversation
zhouyuan
commented
Aug 27, 2025
Member
Author
|
@kevinw66 @PHILO-HE can you please take a look? |
Signed-off-by: Yuan <yuanzhou@apache.org>
zhouyuan
force-pushed
the
wip_fix_openeuler
branch
from
992b104 to
797de66
Compare
PHILO-HE
reviewed
Aug 28, 2025
| elif [[ "$LINUX_DISTRIBUTION" == "openEuler" ]]; then | ||
| # this is workaround for gcc-12.3.1 | ||
| # https://github.com/facebookincubator/velox/blob/b263d9dd8b8910dc642d8fdb0c0adee4b2a1fb29/CMakeLists.txt#L433 | ||
| sed -i "s|no-unknown-warning-option|no-unknown-warning-option -Wno-restrict|g" ../../src/build_velox.sh |
Member
There was a problem hiding this comment.
According to the link below commented in Velox, it seems the gcc community is retargeting the bugs to GCC 12.5. Therefore, I am wondering if we can just submit a Velox PR to include 12.3.x and even 12.4.x in that check of CMakeLists.txt. Assume this issue is not limited to openEuler.
Contributor
Member
There was a problem hiding this comment.
They look similar. If 12.4 is not confirmed, I think we can just include 12.3 in the check at Velox side.
Member
Author
There was a problem hiding this comment.
@kevinw66 do you happen to know is there any plan to upgrade GCC in openeuler-24 recently?
Member
Author
Contributor
PHILO-HE
approved these changes
Aug 28, 2025
Yohahaha
approved these changes
Aug 28, 2025
zhouyuan
changed the title
Member
Author
Closed
16 tasks
zhouyuan
added a commit
to zhouyuan/gluten
that referenced
this pull request
Aug 28, 2025
This patch adds a extra gcc flag -Wno-restrict to workaround the openeuler compiling issue Velox did added this for gcc-12.2.1 however openeuler is using gcc-12.3.1 https://github.com/facebookincubator/velox/blob/main/CMakeLists.txt#L408 fixes: apache#10552 --------- Signed-off-by: Yuan <yuanzhou@apache.org>
zhouyuan
added a commit
that referenced
this pull request
Aug 28, 2025
…10576) * [VL][INFRA] Fix docker build error on Centos-7 (#10522) * [TEST][VL] Reinclude "cast string to timestamp" test (#10532) * [GLUTEN-10552][VL] Fix openEuler compiling issue (#10564) This patch adds a extra gcc flag -Wno-restrict to workaround the openeuler compiling issue Velox did added this for gcc-12.2.1 however openeuler is using gcc-12.3.1 https://github.com/facebookincubator/velox/blob/main/CMakeLists.txt#L408 fixes: #10552 --------- Signed-off-by: Yuan <yuanzhou@apache.org> --------- Signed-off-by: Yuan <yuanzhou@apache.org> Co-authored-by: PHILO-HE <philo@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
This patch adds a extra gcc flag
-Wno-restrictto workaround the openeuler compiling issueVelox did added this for gcc-12.2.1 however openeuler is using gcc-12.3.1
https://github.com/facebookincubator/velox/blob/main/CMakeLists.txt#L408
fixes: #10552
How was this patch tested?
pass GHA