[GLUTEN-10607][MINOR] Fix: Use setSafe in DateWriter to avoid overflow#10581
Merged
zhouyuan merged 1 commit intoapache:mainfrom Sep 3, 2025
Merged
[GLUTEN-10607][MINOR] Fix: Use setSafe in DateWriter to avoid overflow#10581zhouyuan merged 1 commit intoapache:mainfrom
setSafe in DateWriter to avoid overflow#10581zhouyuan merged 1 commit intoapache:mainfrom
Conversation
jiangjiangtian
changed the title
setSafe in DateWriter to avoid overflowsetSafe in DateWriter to avoid overflow
zhouyuan
approved these changes
Sep 1, 2025
Contributor
|
could you create an issue to repeat the exception? |
Contributor
Author
I create an issue here #10607 |
jiangjiangtian
changed the title
setSafe in DateWriter to avoid overflowsetSafe in DateWriter to avoid overflow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
If the Date type is nested within an Array, Map, or Struct, invoking
writeRowmay result in an exception due to DateWriter utilizing the unsafe set interface. Thesetinterface does not reallocate the value buffer in cases of overflow. Consequently, this pull request changes to use the safersetSafeinterface.