[VL] Minor refactoring of get_velox.sh for better readability#10647
Merged
philo-he merged 2 commits intoapache:mainfrom Oct 2, 2025
Merged
[VL] Minor refactoring of get_velox.sh for better readability#10647philo-he merged 2 commits intoapache:mainfrom
philo-he merged 2 commits intoapache:mainfrom
Conversation
philo-he
reviewed
Sep 22, 2025
| if [[ "x$commands_to_run" == "x" ]]; then | ||
| get_velox | ||
| setup_dependencies | ||
| if [[ "$RUN_SETUP_SCRIPT" == "ON" ]]; then |
Member
There was a problem hiding this comment.
Can we also move the check -z "${GLUTEN_VCPKG_ENABLED:-}" here?
Zouxxyy
force-pushed
the
dev/update-scrip
branch
from
f699ad8 to
053e83d
Compare
Zouxxyy
force-pushed
the
dev/update-scrip
branch
from
053e83d to
2a6ad5a
Compare
Contributor
Author
|
@philo-he Can you take a look again thanks, the failed case should be irrelevant. |
philo-he
reviewed
Sep 30, 2025
| if [ "$VELOX_HOME" == "" ]; then | ||
| VELOX_HOME="$CURRENT_DIR/../build/velox_ep" | ||
| fi | ||
| VELOX_SOURCE_DIR="${VELOX_HOME}" |
Member
There was a problem hiding this comment.
It seems not necessary to define VELOX_SOURCE_DIR.
| fi | ||
|
|
||
| apply_compilation_fixes $CURRENT_DIR $VELOX_SOURCE_DIR | ||
| apply_provided_velox_patch "$VELOX_SOURCE_DIR" |
Member
There was a problem hiding this comment.
VELOX_HOME is a basic global variable. I think we can just access it inside the function instead of passing the arg.
| apply_compilation_fixes $CURRENT_DIR $VELOX_SOURCE_DIR | ||
| apply_provided_velox_patch "$VELOX_SOURCE_DIR" | ||
|
|
||
| apply_compilation_fixes "$CURRENT_DIR" "$VELOX_SOURCE_DIR" |
Member
There was a problem hiding this comment.
Ditto. $CURRENT_DIR is accessible inside the function.
Contributor
Author
|
I removed the useless variables, CC @philo-he |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Wrapping the key steps into functions will help everyone understand the flow of the script.
How was this patch tested?