[GLUTEN-10687] Refactor expressionBlacklist to follow Scala style#10688
Merged
FelixYBW merged 1 commit intoapache:mainfrom Sep 13, 2025
Merged
Conversation
beliefer
changed the title
|
Run Gluten Clickhouse CI on x86 |
beliefer
force-pushed
the
expressionBlacklist-follows-scala-style
branch
from
d56044c to
bec303b
Compare
|
Run Gluten Clickhouse CI on x86 |
beliefer
force-pushed
the
expressionBlacklist-follows-scala-style
branch
from
bec303b to
b13d9df
Compare
|
Run Gluten Clickhouse CI on x86 |
beliefer
force-pushed
the
expressionBlacklist-follows-scala-style
branch
from
b13d9df to
5ed559b
Compare
|
Run Gluten Clickhouse CI on x86 |
zml1206
reviewed
Sep 12, 2025
Comment on lines
+278
to
+280
| val blacklistSet = getConf(EXPRESSION_BLACK_LIST) | ||
| .map { | ||
| str => | ||
| str | ||
| .toLowerCase(Locale.ROOT) | ||
| .split(",") | ||
| .map(_.trim()) | ||
| .filter(_.nonEmpty) | ||
| .toSet | ||
| } | ||
| .getOrElse(Set.empty[String]) |
Contributor
There was a problem hiding this comment.
Suggestion:
val blacklistSet = getConf(EXPRESSION_BLACK_LIST)
.map(_.toLowerCase(Locale.ROOT).split(",").map(_.trim()).filter(_.nonEmpty).toSet)
.getOrElse(Set.empty[String])
beliefer
force-pushed
the
expressionBlacklist-follows-scala-style
branch
from
5ed559b to
3801b66
Compare
|
Run Gluten Clickhouse CI on x86 |
zml1206
changed the title
expressionBlacklist to follow Scala style
zml1206
approved these changes
Sep 12, 2025
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
This PR proposes to improve
expressionBlacklistforGlutenConfigand makeexpressionBlacklistfollows Scala style.Fixes: #10687
How was this patch tested?
GA tests.