Skip to content

[VL] Gluten-it: Fix inverted expected vs actual in result mismatch er…#10751

Merged
zhztheplayer merged 1 commit intoapache:mainfrom
zhztheplayer:wip-fix-it-expected
Sep 18, 2025
Merged

[VL] Gluten-it: Fix inverted expected vs actual in result mismatch er…#10751
zhztheplayer merged 1 commit intoapache:mainfrom
zhztheplayer:wip-fix-it-expected

Conversation

@zhztheplayer
Copy link
Copy Markdown
Member

@zhztheplayer zhztheplayer commented Sep 18, 2025

When calling Spark test API SparkUtils.compareAnswers, the expected result should be passed by 2nd parameter, not the 1st one.

Before:

 !== Expected Answer - 2 ==   == Actual Answer - 3 ==
 [102,1]                     [102,1]
 [102,1]                     [102,1]
!                            [102,1]

After:

 == Results ==
 !== Expected Answer - 3 ==   == Actual Answer - 2 ==
 [102,1]                     [102,1]
 [102,1]                     [102,1]
![102,1]    

@zhztheplayer zhztheplayer marked this pull request as ready for review September 18, 2025 09:43
@github-actions github-actions Bot added the TOOLS label Sep 18, 2025
@github-actions
Copy link
Copy Markdown

Run Gluten Clickhouse CI on x86

Copy link
Copy Markdown
Member

@philo-he philo-he left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change makes sense.

@zhztheplayer
Copy link
Copy Markdown
Member Author

Thanks @philo-he .

@zhztheplayer zhztheplayer merged commit 7fc0e17 into apache:main Sep 18, 2025
100 of 101 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants