[GLUTEN-10920][VL] Allow disabling hash/sort shuffle reader buffer#10922
Merged
wForget merged 1 commit intoapache:mainfrom Oct 23, 2025
Merged
[GLUTEN-10920][VL] Allow disabling hash/sort shuffle reader buffer#10922wForget merged 1 commit intoapache:mainfrom
wForget merged 1 commit intoapache:mainfrom
Conversation
FelixYBW
approved these changes
Oct 22, 2025
Contributor
|
@marin-ma why it's onheap copy? shouldn't reducer use netty to load data into direct memory? 
|
Contributor
|
@wForget did you set spark.shuffle.io.preferDirectBufs=False? |
Member
The issue occurs when using Uniffle, rather than the vanilla shuffle. |
Member
Author
Member
Author
warrenzhu25
pushed a commit
to warrenzhu25/gluten
that referenced
this pull request
Jan 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Add buffer to the shuffle read input stream only if
readerBufferSizeis greater than 0.How was this patch tested?
Manually testing internal test case:
add
spark.gluten.sql.columnar.shuffle.readerBufferSize=1MB;conf:add
spark.gluten.sql.columnar.shuffle.readerBufferSize=0;conf:Related issue: #10920