[VL] Upgrade vcpkg builtin-baseline#11004
Conversation
|
@philo-he as Gluten already defined overlays, directly bumping is not working, note initially we have already included some compiler fixes for Gcc-11 |
@zhouyuan, thanks for the review. I assume these overlays are prioritized to be used. With baseline upgraded, I expect we can directly use upstream ports for some new versions of dependency libraries, which can ease the maintenance. |
philo-he
force-pushed
the
upgrade-vcpkg-baseline
branch
2 times, most recently
from
ea31340 to
0f42af0
Compare
|
@philo-he I think we will also need to
|
@zhouyuan, it seems they can be fixed in separate PRs? If so, we can first merge this one once all failures are fixed. I note some libs are not consistent with Velox's setup versions for a long time. |
|
|
||
| if [ ! -d "$VCPKG_ROOT" ] || [ -z "$(ls "$VCPKG_ROOT")" ]; then | ||
| git clone https://github.com/microsoft/vcpkg.git --branch 2023.10.19 "$VCPKG_ROOT" | ||
| git clone https://github.com/microsoft/vcpkg.git --branch 2025.09.17 "$VCPKG_ROOT" |
There was a problem hiding this comment.
2025.09.17
it seems not match the PR desc here
| { | ||
| "$schema": "https://raw.githubusercontent.com/microsoft/vcpkg-tool/main/docs/vcpkg.schema.json", | ||
| "builtin-baseline": "a7b6122f6b6504d16d96117336a0562693579933", | ||
| "builtin-baseline": "4334d8b4c8916018600212ab4dd4bbdc343065d1", |
There was a problem hiding this comment.
could we also add a note for this commit: branch 2025.09.17
There was a problem hiding this comment.
It seems adding comments is not recommended for JSON file. So I just added an Overview section in dev/vcpkg/README.md to clarify this. Thanks.
philo-he
force-pushed
the
upgrade-vcpkg-baseline
branch
from
0f42af0 to
0368c07
Compare
|
I just tested this PR with GCC 13 docker. Those dependency libraries can be built successfully with GCC 13. But when building velox, some errors related to folly are reported to complain the use of uninitialized variable, which should be caused by stricter check of GCC 13. I think we can fix them by upgrading folly in another PR. |
2 participants
What changes are proposed in this pull request?
Upgrade vcpkg baseline to easily use newer libraries and build tools. The latest tag 2025.10.17 requires a higher ninja version which is not compatible with Centos 7 glibc. So tag 2025.09.17 is set in this PR.
How was this patch tested?
CI.