Skip to content

[VL] Configure C++20 standard for dependency libraries#11005

Merged
zhouyuan merged 1 commit intoapache:mainfrom
PHILO-HE:c++20
Nov 7, 2025
Merged

[VL] Configure C++20 standard for dependency libraries#11005
zhouyuan merged 1 commit intoapache:mainfrom
PHILO-HE:c++20

Conversation

@PHILO-HE
Copy link
Member

@PHILO-HE PHILO-HE commented Nov 3, 2025

What changes are proposed in this pull request?

C++ 20 has already been configured for Velox and Gluten C++ code for a long time. To avoid potential issues, this PR changes the standard for dependency libraries for consistency.

How was this patch tested?

CI.

@PHILO-HE
Copy link
Member Author

PHILO-HE commented Nov 3, 2025

@zhouyuan, could you take a look?

@zhouyuan
Copy link
Member

zhouyuan commented Nov 3, 2025

@PHILO-HE The patch looks good, should we make a tag for the docker image for branch-1.5 before merging? Branch-1.5 may be impacted

@PHILO-HE
Copy link
Member Author

PHILO-HE commented Nov 4, 2025

@PHILO-HE The patch looks good, should we make a tag for the docker image for branch-1.5 before merging? Branch-1.5 may be impacted

I will create docker tags for branch-1.5. Assume this will not trigger the build for new image.

@PHILO-HE
Copy link
Member Author

PHILO-HE commented Nov 5, 2025

Just created docker tags for branch-1.5 and they have been pushed to docker hub: https://hub.docker.com/r/apache/gluten/tags

@zhouyuan zhouyuan merged commit 428d344 into apache:main Nov 7, 2025
98 of 100 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants