[VL] Refactor getAggRelInternal in HashAggregateExecTransformer#11040
Merged
philo-he merged 3 commits intoapache:mainfrom Nov 11, 2025
Merged
[VL] Refactor getAggRelInternal in HashAggregateExecTransformer#11040philo-he merged 3 commits intoapache:mainfrom
philo-he merged 3 commits intoapache:mainfrom
Conversation
Contributor
Author
|
@philo-he Can you have a look, thanks |
philo-he
changed the title
philo-he
approved these changes
Nov 10, 2025
Member
philo-he
left a comment
philo-he
left a comment
There was a problem hiding this comment.
Looks good. One minor comment.
@liujiayi771, do you have any comments?
| @@ -272,13 +265,12 @@ abstract class HashAggregateExecTransformer( | |||
| // Add a projection node before aggregation for row constructing. | |||
| // Mainly used for aggregation whose intermediate type is a compound type in Velox. | |||
| // Pre-projection is always not required for final stage. | |||
Member
There was a problem hiding this comment.
Could you help improve this comment to:
Pre-projection is never required for final stages.
Contributor
There was a problem hiding this comment.
@philo-he Yes. Final aggregation does not require pre-projection.
Contributor
|
@philo-he The failed CI tests should not be related to the changes in this PR. |
liujiayi771
approved these changes
Nov 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Refactor from
to
How was this patch tested?