[CH] Improve SparkFloorFunction performance with SVE#11045
Closed
chiranmoyf wants to merge 1 commit intoapache:mainfrom
Closed
[CH] Improve SparkFloorFunction performance with SVE#11045chiranmoyf wants to merge 1 commit intoapache:mainfrom
chiranmoyf wants to merge 1 commit intoapache:mainfrom
Conversation
|
Run Gluten Clickhouse CI on x86 |
1 similar comment
Contributor
|
Run Gluten Clickhouse CI on x86 |
Contributor
It seems related to the changes. cc @chiranmoyf
|
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
Author
|
The build error occurs because the macros are undefined in ClickHouse. We are working on the ClickHouse PR. Once it is merged, the issue should be resolved. |
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
This PR was auto-closed because it has been stalled for 10 days with no activity. Please feel free to reopen if it is still valid. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What changes are proposed in this pull request?
This commit introduces support for the Scalable Vector Extension (SVE) in SparkFloorFunction.
How was this patch tested?
We've used Google's microbenchmark
BM_SparkFloorFunction_For_Float64to test the patch. The results are presented below.We are getting around 2x performance improvement on AWS Graviton3 (m7g.4xlarge).
Note
SVE detection and macros used here are enabled in Clickhouse. We are raising this PR as draft since the Clickhouse PR is under review. Here in the Clickhouse PR for reference - ClickHouse/ClickHouse#85010