[VL] RSS client should push complete rows#11123
Merged
marin-ma merged 2 commits intoapache:mainfrom Nov 21, 2025
Merged
Conversation
Contributor
Author
|
cc: @boneanxs |
boneanxs
approved these changes
Nov 19, 2025
Contributor
There was a problem hiding this comment.
cc @marin-ma @kerwin-zk @wForget a follow up for the #11059
Contributor
|
We should avoid future changes to break this logic again. Could you add unit test for this fix? |
Contributor
wecharyu
force-pushed
the
rss_push_complete_rows
branch
2 times, most recently
from
18e3284 to
49c8c74
Compare
wecharyu
force-pushed
the
rss_push_complete_rows
branch
from
49c8c74 to
05c423c
Compare
Contributor
Author
|
@marin-ma @kerwin-zk Pls help take a look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
#11059 will push data to rss once there are available inMemoryPayload, but for large rows the data may be split into multiple payloads and push multi times.
If there is another worker push data to the same partition, the split row are broken, so we should ensure only the complete rows can be push to rss.
How was this patch tested?