[GLUTEN-11155][CORE] Code cleanup for BasicScanExecTransformer#11156
Merged
beliefer merged 1 commit intoapache:mainfrom Nov 25, 2025
Merged
[GLUTEN-11155][CORE] Code cleanup for BasicScanExecTransformer#11156beliefer merged 1 commit intoapache:mainfrom
beliefer merged 1 commit intoapache:mainfrom
Conversation
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
Contributor
Author
|
cc @kerwin-zk @liujiayi771 @jinchengchenghh @zzcclp |
| List<String> names, | ||
| List<ColumnTypeNode> columnTypeNodes, | ||
| ExpressionNode filter, | ||
| List<ColumnTypeNode> columnTypeNodes, |
Contributor
There was a problem hiding this comment.
Why you move the argument?
Contributor
Author
There was a problem hiding this comment.
Make the order of construct object consistent with parameters. This can help improve readability.
jinchengchenghh
approved these changes
Nov 24, 2025
zhztheplayer
approved these changes
Nov 24, 2025
liujiayi771
approved these changes
Nov 25, 2025
Contributor
Author
|
The two fails tests are not related to this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
This PR proposes to make code cleanup for
BasicScanExecTransformer.Fixes #11155
How was this patch tested?
GA tests.