[GLUTEN-11182][VL] Refactor genSplitInfo for VeloxIteratorApi#11183
Merged
beliefer merged 1 commit intoapache:mainfrom Nov 26, 2025
Merged
[GLUTEN-11182][VL] Refactor genSplitInfo for VeloxIteratorApi#11183beliefer merged 1 commit intoapache:mainfrom
beliefer merged 1 commit intoapache:mainfrom
Conversation
Member
zhztheplayer
left a comment
zhztheplayer
left a comment
There was a problem hiding this comment.
LGTM.
I wonder if we can completely replace JArrayList / JHashMap / JMap with Scala collections in this file, so the style will be more consistent.
zhztheplayer
approved these changes
Nov 25, 2025
Contributor
Author
Yeah, it is perfect if we can make the change. I will try to fix it in future. |
Contributor
Author
|
@zhztheplayer Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
This PR proposes to refactor
genSplitInfoforVeloxIteratorApi.Fixes #11182
How was this patch tested?
GA tests.