[GLUTEN-8782][VL] Add correct suffix to the name of merge_extract companion function#11210
Merged
zhouyuan merged 1 commit intoapache:mainfrom Nov 28, 2025
Merged
[GLUTEN-8782][VL] Add correct suffix to the name of merge_extract companion function#11210zhouyuan merged 1 commit intoapache:mainfrom
zhouyuan merged 1 commit intoapache:mainfrom
Conversation
rui-mo
force-pushed
the
wip_suffix
branch
2 times, most recently
from
835ac86 to
adfd329
Compare
| auto functionName = baseName + "_merge_extract"; | ||
| auto signatures = exec::getAggregateFunctionSignatures(functionName); | ||
| if (signatures.has_value() && signatures.value().size() > 0) { | ||
| // The merge_extract function is registered without suffix. |
Contributor
There was a problem hiding this comment.
nit: Put the comment on line 280.
Contributor
Author
There was a problem hiding this comment.
This comment is true only when the condition is met, so I assume keeping it here is more appropriate. Thanks.
Contributor
|
+1 |
zhouyuan
approved these changes
Nov 28, 2025
zhouyuan
reviewed
Nov 28, 2025
| VELOX_BRANCH=dft-2025_11_26 | ||
| VELOX_ENHANCED_BRANCH=ibm-2025_11_26 | ||
| VELOX_BRANCH=dft-2025_11_26_fix | ||
| VELOX_ENHANCED_BRANCH=ibm-2025_11_26_fix |
Member
There was a problem hiding this comment.
Cc: @FelixYBW
removed one commit from original OAP patches
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Add correct suffix to the name of merge_extract companion function, so we no longer need the change made to Velox IBM/velox@b8da5d0.
How was this patch tested?
Verified with existing unit tests.
Related issue: #8782