Skip to content

[VL] Extract common createHiveConnectorSessionConfig method and use it for Iceberg write#11227

Merged
jinchengchenghh merged 1 commit intoapache:mainfrom
Zouxxyy:dev/fix-hive-conf
Dec 1, 2025
Merged

[VL] Extract common createHiveConnectorSessionConfig method and use it for Iceberg write#11227
jinchengchenghh merged 1 commit intoapache:mainfrom
Zouxxyy:dev/fix-hive-conf

Conversation

@Zouxxyy
Copy link
Copy Markdown
Contributor

@Zouxxyy Zouxxyy commented Nov 29, 2025

What changes are proposed in this pull request?

Currently, the Hive connector's conf is composed of sessionConf + conf.

The HiveConnectorSessionConfig currently used for Iceberg writes is defined separately and misses many configurations, such as partition_path_as_lower_case=false. This causes the case of partition values in the written file paths to be lost.

How was this patch tested?

Add a case "iceberg insert partition table with uppercase partition name"

@github-actions github-actions Bot added the VELOX label Nov 29, 2025
@Zouxxyy
Copy link
Copy Markdown
Contributor Author

Zouxxyy commented Dec 1, 2025

CC @jinchengchenghh @marin-ma for a look, thanks

Copy link
Copy Markdown
Contributor

@jinchengchenghh jinchengchenghh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jinchengchenghh jinchengchenghh merged commit 0d5db62 into apache:main Dec 1, 2025
105 of 106 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants