[VL] Support pass unmapped dynamic and static configs to Velox #11229
Merged
Yohahaha merged 2 commits intoapache:mainfrom Dec 3, 2025
Merged
[VL] Support pass unmapped dynamic and static configs to Velox #11229Yohahaha merged 2 commits intoapache:mainfrom
Yohahaha merged 2 commits intoapache:mainfrom
Conversation
Yohahaha
force-pushed
the
pass-velox-conf
branch
from
640b742 to
bb291bd
Compare
Contributor
Author
kerwin-zk
approved these changes
Dec 2, 2025
liujiayi771
approved these changes
Dec 2, 2025
zhouyuan
reviewed
Dec 2, 2025
| configs[facebook::velox::connector::hive::HiveConfig::kOrcUseColumnNamesSession] = | ||
| conf->get<bool>(kOrcUseColumnNames, true) ? "true" : "false"; | ||
|
|
||
| overwriteVeloxConf(conf.get(), configs, kDynamicBackendConfPrefix); |
Member
There was a problem hiding this comment.
Would this introduce some redundant config set?
Contributor
Author
There was a problem hiding this comment.
only works for unmapped configs, mapped configs use spark defined name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Avoid re-compile and publish whole project when we need overwrite some configs in prod env.
How was this patch tested?