Skip to content

[GLUTEN-11245][CORE] Refactor getNativeSessionConf and getNativeBackendConf for GlutenConfig#11246

Merged
Yohahaha merged 1 commit intoapache:mainfrom
beliefer:11245
Dec 8, 2025
Merged

[GLUTEN-11245][CORE] Refactor getNativeSessionConf and getNativeBackendConf for GlutenConfig#11246
Yohahaha merged 1 commit intoapache:mainfrom
beliefer:11245

Conversation

@beliefer
Copy link
Copy Markdown
Contributor

@beliefer beliefer commented Dec 3, 2025

What changes are proposed in this pull request?

This PR proposes to refactor getNativeSessionConf and getNativeBackendConf for GlutenConfig.
Fixes #11245

How was this patch tested?

GA tests.

@github-actions github-actions Bot added CORE works for Gluten Core VELOX labels Dec 3, 2025
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 3, 2025

Run Gluten Clickhouse CI on x86

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 3, 2025

Run Gluten Clickhouse CI on x86

@beliefer beliefer changed the title [GLUTEN-11245][CORE] Refactor getNativeSessionConf for GlutenConfig [GLUTEN-11245][CORE] Refactor getNativeSessionConf and getNativeBackendConf for GlutenConfig Dec 3, 2025
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 3, 2025

Run Gluten Clickhouse CI on x86

Copy link
Copy Markdown
Member

@zhouyuan zhouyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice refactor! It looks like the CK backend is impacted

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 4, 2025

Run Gluten Clickhouse CI on x86

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 4, 2025

Run Gluten Clickhouse CI on x86

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 4, 2025

Run Gluten Clickhouse CI on x86

1 similar comment
@beliefer
Copy link
Copy Markdown
Contributor Author

beliefer commented Dec 6, 2025

Run Gluten Clickhouse CI on x86

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 7, 2025

Run Gluten Clickhouse CI on x86

@beliefer beliefer requested a review from zhouyuan December 7, 2025 12:26
@beliefer
Copy link
Copy Markdown
Contributor Author

beliefer commented Dec 7, 2025

@zhouyuan This PR is ready!

@beliefer
Copy link
Copy Markdown
Contributor Author

beliefer commented Dec 7, 2025

@Yohahaha Yohahaha merged commit 56b7f75 into apache:main Dec 8, 2025
105 of 107 checks passed
@beliefer
Copy link
Copy Markdown
Contributor Author

beliefer commented Dec 8, 2025

@Yohahaha @zhouyuan Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CORE works for Gluten Core VELOX

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CORE] Refactor getNativeSessionConf and getNativeBackendConf for GlutenConfig

3 participants