[CORE] Get correct fallback reason on nodes without logicalLink#11295
Merged
liujiayi771 merged 1 commit intoapache:mainfrom Dec 16, 2025
Merged
[CORE] Get correct fallback reason on nodes without logicalLink#11295liujiayi771 merged 1 commit intoapache:mainfrom
liujiayi771 merged 1 commit intoapache:mainfrom
Conversation
|
Run Gluten Clickhouse CI on x86 |
liujiayi771
force-pushed
the
sort_fallback
branch
from
dad63e1 to
3d75a55
Compare
|
Run Gluten Clickhouse CI on x86 |
Contributor
Author
|
Before: After: |
liujiayi771
force-pushed
the
sort_fallback
branch
from
3d75a55 to
f97106d
Compare
|
Run Gluten Clickhouse CI on x86 |
Contributor
Author
ulysses-you
approved these changes
Dec 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
This PR adds a fallback mechanism to attempt retrieving the fallback reason from a SparkPlan node's tags when its
logicalLinkis unavailable. Some SparkPlan nodes, such as theSortExecgenerated by Spark'sEnsureRequirementsrule, inherently lack alogicalLink. Furthermore, some plan conversion rules in Gluten might omit callingcopyTagsFrom, leading to the loss of the originallogicalLink.In such cases, if the node falls back, the fallback reason might be stored within the physical node's tags. This change attempts to retrieve the reason from there as a best-effort approach.
How was this patch tested?
Add a test case when window sort fallback. Before this change, the fallback reason was a generic "Gluten does not touch it or does not support it". After the change, it can display a more precise reason, such as "[FallbackByUserOptions] Validation failed on node Sort", which is retrieved from the physical node's tags.