Use build/mvn wrapper in velox_backend_x86 workflow#11332
Merged
yaooqinn merged 11 commits intoapache:mainfrom Jan 5, 2026
Merged
Use build/mvn wrapper in velox_backend_x86 workflow#11332yaooqinn merged 11 commits intoapache:mainfrom
yaooqinn merged 11 commits intoapache:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates the velox_backend_x86 workflow to use the Maven wrapper (build/mvn) instead of directly calling mvn, ensuring consistent Maven versions across all CI jobs. The PR also simplifies the Maven download mechanism in the wrapper script itself.
Key changes:
- Updated
MVN_CMDenvironment variable frommvn -ntptobuild/mvn -ntp - Removed Maven installation steps from Ubuntu and CentOS jobs
- Simplified Maven download to use Maven Central directly instead of Apache mirror service with fallback
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
build/mvn |
Simplified Maven download by using Maven Central directly instead of Apache closer.lua with archive.apache.org fallback |
.github/workflows/velox_backend_x86.yml |
Updated workflow to use build/mvn wrapper, removed Maven installation steps, and added build/mvn to workflow trigger paths |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
@PHILO-HE Can you take a look when you have some time? |
Member
Author
|
Thank you @zhztheplayer for the review |
Angryrou
pushed a commit
to Angryrou/incubator-gluten
that referenced
this pull request
Jan 5, 2026
* Use build/mvn wrapper in velox_backend_x86 workflow * Install wget in ubuntu jobs for Maven wrapper compatibility * Use absolute path for build/mvn in Docker container * Build gluten-it from project root using -pl option * Build gluten-it from root in celeborn test job * Build gluten-it from root in tpc-test-ubuntu job * Revert to separate gluten-it builds - not in main reactor * Use absolute path for MVN_CMD in gluten-it builds * use repo.mvn * cd
QCLyu
pushed a commit
to QCLyu/incubator-gluten
that referenced
this pull request
Jan 8, 2026
* Use build/mvn wrapper in velox_backend_x86 workflow * Install wget in ubuntu jobs for Maven wrapper compatibility * Use absolute path for build/mvn in Docker container * Build gluten-it from project root using -pl option * Build gluten-it from root in celeborn test job * Build gluten-it from root in tpc-test-ubuntu job * Revert to separate gluten-it builds - not in main reactor * Use absolute path for MVN_CMD in gluten-it builds * use repo.mvn * cd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
This PR updates the
.github/workflows/velox_backend_x86.ymlworkflow to use thebuild/mvnwrapper script instead of directly callingmvn.Changes:
MVN_CMDenvironment variable frommvn -ntptobuild/mvn -ntpSETUPenvironment variable and related helper script callsbuild/mvnto the workflow trigger paths to ensure workflow runs when the wrapper is modifiedBenefits:
How was this patch tested?
build/mvnbuild/mvn) handles Maven installation automatically